Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove src/backend #3413

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Remove src/backend #3413

merged 3 commits into from
Apr 22, 2022

Conversation

TueeNguyen
Copy link
Contributor

@TueeNguyen TueeNguyen commented Apr 6, 2022 •
edited by DukeManh
Loading

Issue This PR Addresses

Part of #2777

  • I'm removing the code here
  • Will change the docs after this PR

Type of Change

  • Bugfix: Change which fixes an issue
  • New Feature: Change which adds functionality
  • Documentation Update: Change which improves documentation
  • UI: Change which improves UI

Description

  • Remove most of backend code

Steps to test the PR

  • cp config/env.development .env

  • pnpm services:start parser studio db kong rest meta

  • pnpm db:init

  • I guess if pnpm services:start run normally that's fine

  • Need to keep in mind if other parts of telescope use anything from legacy backend

  • Need to merge and test on staging to know exactly what will happen

Checklist

  • Quality: This PR builds and passes our npm test and works locally
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not (if applicable)
  • Documentation: This PR includes updated/added documentation to user exposed functionality or configuration variables are added/changed or an explanation of why it does not(if applicable)

@gitpod-io
Copy link

gitpod-io bot commented Apr 6, 2022

@TueeNguyen TueeNguyen marked this pull request as ready for review April 6, 2022 20:37
@TueeNguyen TueeNguyen changed the title Remove backend Remove src/backend Apr 6, 2022
@TDDR
Copy link
Contributor

TDDR commented Apr 7, 2022

I did a gh pr checkout 3413 and then pnpm services:start and got this error
image

Did I do something wrong?

@TDDR TDDR requested review from TDDR and humphd April 7, 2022 01:16
@TueeNguyen
Copy link
Contributor Author

@TDDR Ah they timed out, can you try again?

TDDR
TDDR previously approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@TDDR TDDR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out on local and all seems to be working. I'm not sure of the greater ramifications of removing all this code but it looks to be working.

RC-Lee
RC-Lee reviewed Apr 7, 2022
View reviewed changes
package.json Outdated Show resolved Hide resolved
TueeNguyen
TueeNguyen commented Apr 7, 2022
View reviewed changes
docker/development.yml Outdated Show resolved Hide resolved
JerryHue
JerryHue previously approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@JerryHue JerryHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went through all files with Tue on a meeting, so I am sure that this can be approved now. We have to be aware, though, that we modified the CI workflows, so when we merge, we gotta be attentive to the build status.

humphd
humphd requested changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. A few questions.

config/env.development
# PORT is the port used by the web server
PORT=3000

# API_URL is the URL of the Telescope Web API server. Change this to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing we lose by doing this is the ability to work on the front-end locally, but use the staging server as your back-end. Probably that's OK, and we should migrate to using GitPod or EC2 cloud instances instead, so you can run everything at once.

config/env.development Outdated Show resolved Hide resolved
config/env.development Show resolved Hide resolved
docker/production.yml Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/web/app/src/config.ts Show resolved Hide resolved
menghif
menghif previously requested changes Apr 7, 2022
View reviewed changes
package.json Show resolved Hide resolved
@tpmai22 tpmai22 dismissed stale reviews from joelazwar, JiaHua-Zou, and TDDR via d64b420 April 22, 2022 16:08
DukeManh
DukeManh previously approved these changes Apr 22, 2022
View reviewed changes
JiaHua-Zou
JiaHua-Zou previously approved these changes Apr 22, 2022
View reviewed changes
@aserputov aserputov dismissed stale reviews from JiaHua-Zou and DukeManh via 3f1a035 April 22, 2022 20:06
@TueeNguyen
Remove backend:
5f01b14 
- Remove all tests from /test
- Remove src/backend
- Remove API_URL related code in front-end + other files
- Remove 'telescope' container in production.yml
- Remove backend dependencies from package.json
- Change some in config files
@TueeNguyen
Update lock file
1c2e2d4
@TueeNguyen
Update package.json + lock file
41523c8
@TueeNguyen TueeNguyen merged commit 61dbefe into Seneca-CDOT:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sirinoks sirinoks sirinoks approved these changes

@joelazwar joelazwar joelazwar approved these changes

@JiaHua-Zou JiaHua-Zou JiaHua-Zou approved these changes

@DukeManh DukeManh DukeManh left review comments

@TDDR TDDR TDDR left review comments

@RC-Lee RC-Lee Awaiting requested review from RC-Lee

@menghif menghif Awaiting requested review from menghif

@JerryHue JerryHue Awaiting requested review from JerryHue

@Kevan-Y Kevan-Y Awaiting requested review from Kevan-Y

@HyperTHD HyperTHD Awaiting requested review from HyperTHD

@humphd humphd Awaiting requested review from humphd

Assignees

@TueeNguyen TueeNguyen

Labels
None yet
Projects
None yet
Milestone
3.0 Release
Development

Successfully merging this pull request may close these issues.